pygod icon indicating copy to clipboard operation
pygod copied to clipboard

Problem for CoLA and ANEMONE models.

Open 1017027994zjj opened this issue 3 years ago • 1 comments

The codes for masking the target nodes is wrong. The target node is the first node in subgraph after the RandomWalk sample, while you mask the last node. The performance of CoLa and ANEMONE will improve 2% by fixing the bug.

Wrong codes in CoLA(line 361~364) batch_feature = torch.cat( (batch_feature[:, :-1, :], added_feat_zero_row, batch_feature[:, -1:, :]), dim=1)

Correct codes: batch_feature = torch.cat( (added_feat_zero_row, batch_feature[:, 1:, :], batch_feature[:, 0:1, :]), dim=1)

Wrong codes in ANEMONE(line 288~289 and 429~430) bf = torch.cat( (bf[:, :-1, :], added_feat_zero_row, bf[:, -1:, :]), dim=1)

Correct codes: bf = torch.cat( (added_feat_zero_row, bf[:, 1:, :], bf[:, 0 : 1, :]), dim=1)

1017027994zjj avatar Aug 16 '22 11:08 1017027994zjj

Thanks a lot for you issue. Could you please help us to create a PR? So that your contribution will be shown in the repo later.

kayzliu avatar Aug 16 '22 20:08 kayzliu

CoLA is now refactored.

kayzliu avatar May 12 '23 03:05 kayzliu