pytorch_geometric icon indicating copy to clipboard operation
pytorch_geometric copied to clipboard

Sparse version of `nn.dense.dense_mincut_pool`

Open xiaohan2012 opened this issue 1 year ago • 6 comments
trafficstars

🚀 The feature, motivation and pitch

The nn.dense.dense_mincut_pool operator requires the input adjacency matrix to be dense. This requirement does not scale well as the matrix size grows. We may use operations on sparse matrix to address this issue.

Alternatives

Additional context

No response

xiaohan2012 avatar Mar 28 '24 09:03 xiaohan2012

If you see any major flaw in this idea, please let me know. I'd be glad to contribute to this idea.

xiaohan2012 avatar Mar 28 '24 09:03 xiaohan2012

Similar issue: https://github.com/pyg-team/pytorch_geometric/issues/7364

xiaohan2012 avatar Mar 28 '24 13:03 xiaohan2012

We initially designed it this way because mincut_pool needs to operate on dense adjacency matrices anyway in consecutive applications. I am definitely open though to support it for both sparse and dense adjacency matrices.

rusty1s avatar Mar 28 '24 14:03 rusty1s

Hi, I'm interested in making a pull request. Meanwhile I cannot push my branch to this project. Maybe I need to be added to this project first?

xiaohan2012 avatar Apr 24 '24 11:04 xiaohan2012

If you want to contribute to PyG, you need to fork this repo, push the changes to your local fork, and then submit a PR to PyG.

rusty1s avatar Apr 26 '24 12:04 rusty1s

Thanks for the tips. I made a draft PR https://github.com/pyg-team/pytorch_geometric/pull/9243 but have some questions. It would be great if someone could take a look at it.

xiaohan2012 avatar Apr 26 '24 12:04 xiaohan2012