xarray
xarray copied to clipboard
Update release workflows
Our release action failed :( https://github.com/pydata/xarray/actions/runs/15565419295/job/43828236592 Looks like something else was dragging in typing_extensions earlier.
Actually I don't understand what happened here.
One action failed and another succeeeded: https://github.com/pydata/xarray/actions/workflows/pypi-release.yaml . the release is on pypi.
Does anyone understand what's going on?
hmmm, looks like the pipeline from the Release succeeded, the pipeline from the tag failed, so it successfully pushed to PyPI
it looks like that's because we don't run the verify check before the release?
Change:
from typing_extensions import Self
to
if TYPE_CHECKING:
from typing_extensions import Self
at https://github.com/pydata/xarray/blob/f1a2c08f21a8237c082913fcad2d77469448cf4c/xarray/core/accessor_dt.py#L8C1-L8C35
Apologies, I didn't see this PR before creating:
- #10413
which guards the typing_extension import as done elsewhere in the code base.