xarray icon indicating copy to clipboard operation
xarray copied to clipboard

Allow for inline_array specification in open_zarr through from_array_kwargs

Open hansmohrmann opened this issue 6 months ago • 2 comments

This is probably not the best way to do this, but I figured I would start with the simplest way and go from there.

inline_array snakes its way through the codebase all the way to _maybe_chunk where it gets resolved against from_array_kwargs; if you provide it in from_array_kwargs and explicitly to open_dataset, you get @dcherian's error message. So with open_zarr you can't provide it in from_array_kwargs since the default open_dataset value is used (False); this PR just removes it from from_array_kwargs and passes that value to open_dataset.

Pros:

  • Doesn't require changing the signature of anything.

Cons:

  • open_zarr is now the one place where you can use inline_array in from_array_kwargs, which might lead to some confusion down the line.
  • Have tied the default value in open_dataset to open_zarr.

So alternatively, I could modify open_zarr with another inline_array arg.

  • [x] Closes #8095

hansmohrmann avatar May 29 '25 15:05 hansmohrmann

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. If you have questions, some answers may be found in our contributing guidelines.

welcome[bot] avatar May 29 '25 15:05 welcome[bot]

@TomNicholas

hansmohrmann avatar May 29 '25 15:05 hansmohrmann