pydata-sphinx-theme icon indicating copy to clipboard operation
pydata-sphinx-theme copied to clipboard

Published 20 hours ago • verified publisher icon pydata

Split up bootstrap and theme css

Open hoetmaaiers opened this issue 5 years ago • 2 comments

Split up bootstrap and theme.css in 2 different output results. Bootstrap overrides and mixins should be included in both css outputs.

hoetmaaiers avatar Apr 03 '20 07:04 hoetmaaiers

@choldgraf isn't this one solved with the new organization of the css files ?

12rambau avatar May 04 '22 22:05 12rambau

I don't believe so, because we actually import all of bootstrap in our index.scss, I believe:

https://github.com/pydata/pydata-sphinx-theme/blob/2dd6888993ca5ed56dfe712a89ef73ecde9a2baa/src/pydata_sphinx_theme/assets/styles/index.scss#L19

I think that resolving this issue would mean explicitly linking the bootstrap.css file in Sphinx, and linking our CSS after that, so they are two separate links. I agree this is a good idea so that it's clearer which rules are coming from Bootstrap vs. our theme CSS.

choldgraf avatar May 05 '22 08:05 choldgraf