jiter icon indicating copy to clipboard operation
jiter copied to clipboard

upgrade to smallvec 2 to fix invariant lifetimes

Open samuelcolvin opened this issue 1 year ago • 2 comments

Still failing due to LazyIndexMap

samuelcolvin avatar Sep 09 '24 11:09 samuelcolvin

CodSpeed Performance Report

Merging #131 will degrade performances by 29.45%

Comparing invariant-lifetimes (e054b28) with main (dd25fd0)

Summary

⚡ 2 improvements ❌ 4 regressions ✅ 67 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main invariant-lifetimes Change
lazy_map_lookup_1_10 8.9 µs 11.8 µs -24.36%
lazy_map_lookup_2_20 25.5 µs 20.4 µs +25.07%
lazy_map_lookup_3_50 51.6 µs 42.5 µs +21.39%
pass1_jiter_value 37.8 µs 45.2 µs -16.42%
true_object_jiter_value 31.8 µs 45.1 µs -29.45%
python_parse_true_array 15.1 µs 16.9 µs -10.77%

codspeed-hq[bot] avatar Sep 09 '24 11:09 codspeed-hq[bot]

Codecov Report

Attention: Patch coverage is 92.55814% with 16 lines in your changes missing coverage. Please review.

Project coverage is 95.09%. Comparing base (dd25fd0) to head (e054b28). Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
crates/jiter/src/lazy_index_map.rs 92.38% 16 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   94.91%   95.09%   +0.18%     
==========================================
  Files          12       12              
  Lines        1908     1999      +91     
==========================================
+ Hits         1811     1901      +90     
- Misses         97       98       +1     
Files with missing lines Coverage Δ
crates/jiter/src/python.rs 98.55% <100.00%> (+1.54%) :arrow_up:
crates/jiter/src/value.rs 97.10% <100.00%> (-0.02%) :arrow_down:
crates/jiter/src/lazy_index_map.rs 93.36% <92.38%> (-4.62%) :arrow_down:

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd25fd0...e054b28. Read the comment docs.

codecov[bot] avatar Sep 09 '24 11:09 codecov[bot]

Would be made irrelevant by #184

davidhewitt avatar Jan 23 '25 21:01 davidhewitt