pycon.tw
pycon.tw copied to clipboard
Add Review Stages Setting
Types of changes
- [ ] Bugfix
- [x] New feature
- [ ] Refactoring
- [ ] Breaking change (any change that would cause existing functionality to not work as expected)
- [ ] Documentation Update
- [ ] Other (please describe)
Description
- Initialize setting review / proposal stage page
- Created new branch from current master branch and cherrypicked from #782
Steps to Test This Pull Request
Steps to reproduce the behavior:
- Login with admin account
- Go to 'Review Stages' page
- Click hotkeys in the 'Set Review Stage' section
- Submit
Expected behavior
- [ ] Only admin can see this page.
- [x] Review stages hotkeys corresponding to Proposal Review System Documentation.
- [x] Submit and update the setting to dj-registry.
- [x] Rendering current stage settings to the frontend.
Related Issue
#782
More Information
Codecov Report
Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.
Project coverage is 74.44%. Comparing base (
0e6ad43) to head (ee689cc). Report is 1 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/reviews/views.py | 97.91% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1204 +/- ##
==========================================
+ Coverage 74.03% 74.44% +0.40%
==========================================
Files 81 81
Lines 3062 3115 +53
==========================================
+ Hits 2267 2319 +52
- Misses 795 796 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
- Consider organizing the whole commit history again, leaving only important commits for reviewers.
- Please ensure the feature runs well with the upcoming bootstrap for 2025 (#1213)