pycon.tw icon indicating copy to clipboard operation
pycon.tw copied to clipboard

fix(dev): update the way it attach to the dev container

Open mattwang44 opened this issue 1 year ago • 2 comments

Types of changes

  • [x] Bugfix

Description

The current dev script is reported as not working on Windows and Linux. Note that the author and reviewers of #1172 are all mac users.

What this PR does are:

  • Change the container-attaching behavior
  • Adopt docker compose v2
  • Slightly refactoring for better readability

todos

  • [ ] verify on Windows (@ken71301 will help on this part)
  • [x] verify on Max
  • [x] verify on Linux (GitHub codespace)

mattwang44 avatar Apr 18 '24 15:04 mattwang44

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.16%. Comparing base (53b0638) to head (7341b7d). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
- Coverage   71.19%   71.16%   -0.03%     
==========================================
  Files          84       84              
  Lines        3451     3451              
==========================================
- Hits         2457     2456       -1     
- Misses        994      995       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 18 '24 15:04 codecov[bot]

still not working on windows, so it's converted to a draft

mattwang44 avatar May 06 '24 08:05 mattwang44