pycon.tw icon indicating copy to clipboard operation
pycon.tw copied to clipboard

chore: remove deprecated schedule model, views, page, ...etc

Open mattwang44 opened this issue 2 years ago • 4 comments

Types of changes

  • [ ] Bugfix
  • [ ] New feature
  • [x] Refactoring
  • [ ] Breaking change (any change that would cause existing functionality to not work as expected)
  • [ ] Documentation Update
  • [ ] Other (please describe)

Description

Before 2021, we used to have a schedule model storing the generated HTML code of schedule data, and being displayed on the schedule page. However, this behavior has been deprecated after we created the brand new front-end project in 2021.

Note that I only deleted/modified templates and statics from the 2023 code.

Steps to Test This Pull Request

  • Go to django admin
  • Should not see schedule model

Expected behavior

  • All currently active behavior should remain unaffected.
  • Deprecated schedule-related behaviors are not functioning anymore.

mattwang44 avatar Mar 15 '23 14:03 mattwang44

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.16%. Comparing base (fca6fd2) to head (134b60e). Report is 1 commits behind head on master.

Files Patch % Lines
src/events/views.py 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1132      +/-   ##
==========================================
+ Coverage   71.19%   73.16%   +1.96%     
==========================================
  Files          84       83       -1     
  Lines        3451     3115     -336     
==========================================
- Hits         2457     2279     -178     
+ Misses        994      836     -158     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 16 '23 02:03 codecov-commenter

@erik1110 any progress here?

mattwang44 avatar Jun 12 '23 05:06 mattwang44

rebased

mattwang44 avatar Oct 10 '23 18:10 mattwang44

Please let me know if this refactoring PR is either unwanted or still wanted. I wouldn't take any further action for now as it has been forgotten for quite a long time....

mattwang44 avatar Apr 04 '24 16:04 mattwang44

rebased

mattwang44 avatar Apr 15 '24 09:04 mattwang44