pycon.tw icon indicating copy to clipboard operation
pycon.tw copied to clipboard

feat: add category filter for proposal table

Open dabingnai opened this issue 3 years ago • 3 comments

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change. Please put an x in the box that applies

  • [ ] Bugfix
  • [x] New feature
  • [ ] Refactoring
  • [ ] Breaking change (any change that would cause existing functionality to not work as expected)
  • [ ] Documentation Update
  • [ ] Other (please describe)

Description

Describe what the change is Add category filed to proposal table. When you click on a category, the list of proposals will be filtered by the category you selected.

Steps to Test This Pull Request

Steps to reproduce the behavior:

  1. Go to review page
  2. Click on category filed

Expected behavior

Show the proposal list which was be filtered.

Related Issue

If applicable, refernce to the issue related to this pull request.

More Information

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here. You may also want to refer to how to wirte the perfect pull request

https://user-images.githubusercontent.com/31035650/162525223-95f100f8-a7d8-4bef-a44b-37056f6d0a64.mov

dabingnai avatar Apr 08 '22 20:04 dabingnai

Codecov Report

Merging #1066 (213b9b6) into master (77a954a) will decrease coverage by 0.15%. The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
- Coverage   69.29%   69.14%   -0.16%     
==========================================
  Files          82       82              
  Lines        3306     3315       +9     
==========================================
+ Hits         2291     2292       +1     
- Misses       1015     1023       +8     
Impacted Files Coverage Δ
src/reviews/views.py 31.78% <11.11%> (-1.56%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77a954a...213b9b6. Read the comment docs.

codecov-commenter avatar Apr 08 '22 20:04 codecov-commenter

just for the record, the designer wants to change the UX flow:

  • 每一列的 category clickable -> not clickable
  • header 上的 category 部分變成一個 dropdown,裡面有各個類別和一個 all 可以選

mattwang44 avatar Apr 09 '22 13:04 mattwang44

related issue: #759

mattwang44 avatar Apr 29 '22 06:04 mattwang44

Duplicated and implemented in #1145

josix avatar Nov 27 '23 02:11 josix