pyopenssl icon indicating copy to clipboard operation
pyopenssl copied to clipboard

change empty CRL get_revoked to empty tuple

Open thecubic opened this issue 6 years ago • 2 comments

resolves remaining issue in #258 by switching empty get_revoked return to effective empty tuple.

This was breaking functional tests in a pyOpenSSL integration.

thecubic avatar Jul 31 '19 18:07 thecubic

Ugh, how did we miss reviewing this for so long. I'm concerned about changing this because while it obviously makes more sense, this has been like this for 7 years now so presumably there are people out there depending on the None behavior.

reaperhulk avatar Nov 18 '19 02:11 reaperhulk

@thecubic after an almost comically long period of time I think we can merge this is if you can add a changelog entry noting this and linking to this PR (in backwards incompatible changes please).

reaperhulk avatar Feb 21 '21 04:02 reaperhulk