pyopenssl icon indicating copy to clipboard operation
pyopenssl copied to clipboard

SSL_CTX_set_ciphersuites for tlsv1.3 context

Open BillyGLW opened this issue 1 year ago • 2 comments

Linking: https://github.com/pyca/pyopenssl/issues/1224

As cffi binding allows to use SSL_CTX_set_ciphersuites - adaptation for setting the ciphers in context of TLSv1.3 can be made.

BillyGLW avatar Feb 03 '24 23:02 BillyGLW

Isn't it a bit unusual to hijack the test of another method, just because the two methods require bytes as input?

jlaine avatar Jun 24 '24 21:06 jlaine

Isn't it a bit unusual to hijack the test of another method, just because the two methods require bytes as input?

for me it would make more sense if there would be additional test that calls both of these methods simultaneously (as it is intended), so that parametrized ones can test it individually based on bytes input and context that changes (or raises exception due to typerror).. but it also require test_set_ciphersuites to be parametrized. So, i also think that in current form it will be better to separate them

BillyGLW avatar Jun 24 '24 22:06 BillyGLW