pyopenssl icon indicating copy to clipboard operation
pyopenssl copied to clipboard

Missing export of `OpenSSL.SSL.FILETYPE_ASN1`

Open ChristianStadelmann opened this issue 2 years ago • 1 comments

There is a mismatch between documentation of OpenSSL.SSL and the real behavior.

Steps to reproduce:

  1. install pyopenssl
  2. open a python shell
  3. In the shell, execute: import OpenSSL
  4. In the shell, execute: print(OpenSSL.SSL.FILETYPE_PEM)
  5. In the shell, execute: print(OpenSSL.SSL.FILETYPE_ASN1)

What happens:

import OpenSSL
>>> print(OpenSSL.SSL.FILETYPE_PEM)
1
>>> print(OpenSSL.SSL.FILETYPE_ASN1)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'OpenSSL.SSL' has no attribute 'FILETYPE_ASN1'

What should happen:

no error. The documentation claims that FILETYPE_ASN1 should be available, so it should work.

Additional info:

The code behavior is expected, see the imports of SSL.py from OpenSSL.crypto, this looks like a mismatch between documentation and code to me. Reading the value from OpenSSL.crypto.FILETYPE_ASN1 works fine (workaround).

Installed version: pyopenssl-23.1.1

ChristianStadelmann avatar May 25 '23 14:05 ChristianStadelmann

We'd be happy to take a PR to fix this (Either the documentation or adding the export from crypto to SSL).

reaperhulk avatar May 27 '23 17:05 reaperhulk