cryptography
cryptography copied to clipboard
pyca
pass or collect comments for ssh private keys
It's on my TODO list for this weekend.
On Fri, Jun 9, 2023 at 12:53 PM James Z.M. Gao @.***> wrote:
@alex https://github.com/alex could you plz review this pr?
— Reply to this email directly, view it on GitHub https://github.com/pyca/cryptography/pull/9019#issuecomment-1584884169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGBFDMIQJMTC3WV5KRYTXKNIJ3ANCNFSM6AAAAAAYZH4S6U . You are receiving this because you were mentioned.Message ID: @.***>
-- All that is necessary for evil to succeed is for good people to do nothing.
IMO, this signature is too foreign to the rest of our API surface. Another (possibly bad) idea: should we have a separate loader load_ssh_key_with_comment that is documented as returning comment bytes (e.g. Tuple[PrivateKeyType, bytes])?
@reaperhulk another api is ok, but most codes of the new api have to be copied directly from the original one
No activity here in over a year. The approach needs to be rethought, but we're willing to take a PR for comment parsing still. We recommend discussing the API on the issue first.