cryptography
cryptography copied to clipboard
add support custom comments when formatting openssh private keys
The comment field is left empty when formatting as openssh key protocol. can we support to custom this comment field?
I think we'd accept a PR that added support to https://cryptography.io/en/latest/hazmat/primitives/asymmetric/serialization/#cryptography.hazmat.primitives.serialization.KeySerializationEncryptionBuilder
when parsing from bytes, the comment is also lost.
I think we'd also be happy to take a PR exposing it.
On Fri, Jun 2, 2023 at 1:26 PM James Z.M. Gao @.***> wrote:
when parsing from bytes, the comment is also lost.
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
-- All that is necessary for evil to succeed is for good people to do nothing.
I think we'd also be happy to take a PR exposing it. … On Fri, Jun 2, 2023 at 1:26 PM James Z.M. Gao @.> wrote: when parsing from bytes, the comment is also lost. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.> -- All that is necessary for evil to succeed is for good people to do nothing.
@alex here is a simple pr to fix this issue
any comments about this issue or the pr?
I think we'd also be happy to take a PR exposing it. … On Fri, Jun 2, 2023 at 1:26 PM James Z.M. Gao @.> wrote: when parsing from bytes, the comment is also lost. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: _@**.**_> -- All that is necessary for evil to succeed is for good people to do nothing.
@alex here is a simple pr to fix this issue
@alex any other way to fix this issue?