cryptography
cryptography copied to clipboard
pyca
Test against OpenSSL from infra on aarch64
Right now we only test against system OpenSSL in aarch64, we should test against the openssl we build in infra.
I think we don't actually test against our openssl for manylinux2010 or manylinux_2_24 either do we?
We don't ever run tests in those containers, no.
On Sun, Apr 25, 2021 at 12:30 AM Paul Kehrer @.***> wrote:
I think we don't actually test against our openssl for manylinux2010 or manylinux_2_24 either do we?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pyca/cryptography/issues/6006#issuecomment-826251905, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGBATYJY65GB6463VIOTTKOLEXANCNFSM43QHCSHQ .
-- All that is necessary for evil to succeed is for good people to do nothing.
This requires a bit more thought to prevent a continued explosion in CI size. Possibly should be a single test run during wheel building when we revamp the builders to allow publishing?
That expands the sdist to wheel window by a few minutes, which I think we want to avoid?
בתאריך יום א׳, 14 בנוב׳ 2021, 16:25, מאת Paul Kehrer < @.***>:
This requires a bit more thought to prevent a continued explosion in CI size. Possibly should be a single test run during wheel building when we revamp the builders to allow publishing?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pyca/cryptography/issues/6006#issuecomment-968366407, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGBGLBWTU5U2X4LZ5LRLUMASNRANCNFSM43QHCSHQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Ideally yes, although we already have a model now where we build all the wheels, download them, then upload them immediately after the sdist. Additional time spent won't widen the sdist/wheel gap any more, but it would be irritating (and introduce more variables for ephemeral failure of course).
I don't understand how running tests in teh wheel builder wouldn't widen that window?
On Sun, Nov 14, 2021 at 4:33 PM Paul Kehrer @.***> wrote:
Ideally yes, although we already have a model now where we build all the wheels, download them, then upload them immediately after the sdist. Additional time spent won't widen the sdist/wheel gap any more, but it would be irritating (and introduce more variables for ephemeral failure of course).
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pyca/cryptography/issues/6006#issuecomment-968367597, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGBHZIVBYV2JNX7BYOXLUMATLHANCNFSM43QHCSHQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- All that is necessary for evil to succeed is for good people to do nothing.
Because we don't upload sdist until after we download the wheels now. All the wheels are built by directly checking out the tag, building a local sdist from tag, then building wheel from that local sdist.
Ah, I forgot we made that change. Yes, changing the builders to do a full run of the tests makes good sense to me.
On Sun, Nov 14, 2021 at 5:35 PM Paul Kehrer @.***> wrote:
Because we don't upload sdist until after we download the wheels now. All the wheels are built by directly checking out the tag, building a local sdist from tag, then building wheel from that local sdist.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.
-- All that is necessary for evil to succeed is for good people to do nothing.