PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Removing `run-tests.py` file.

Open prady0t opened this issue 1 year ago • 6 comments

Description

Trying to remove run-tests.py file.

prady0t avatar Jun 14 '24 16:06 prady0t

Yet to add conftest.py file

prady0t avatar Jun 14 '24 16:06 prady0t

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.45%. Comparing base (91c9744) to head (e321ede). Report is 210 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4180   +/-   ##
========================================
  Coverage    99.45%   99.45%           
========================================
  Files          288      288           
  Lines        22092    22092           
========================================
  Hits         21972    21972           
  Misses         120      120           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 14 '24 16:06 codecov[bot]

I think I messed up the branch. I'm having problems while pushing changes. I've made the changes for now.

prady0t avatar Jun 15 '24 12:06 prady0t

@prady0t Is your branch still having problems? Do you need help fixing the branch?

kratman avatar Jun 17 '24 15:06 kratman

@prady0t Is your branch still having problems? Do you need help fixing the branch?

I can work with this, although I made a lot of commits.

prady0t avatar Jun 17 '24 15:06 prady0t

No worries, we'll squash merge anyway, but to learn how to rewrite history would be up to you as an exercise

agriyakhetarpal avatar Jun 17 '24 15:06 agriyakhetarpal

@prady0t, could you fix the failure in the style jobs so that the tests can run?

agriyakhetarpal avatar Jul 10 '24 08:07 agriyakhetarpal

@prady0t, could you fix the failure in the style jobs so that the tests can run?

Done. I removed lot of code lines from conftest.py file and now we are using -m for everything. If a user runs pytest without any marker value, it runs all the tests, otherwise only those specified by -m flag.

prady0t avatar Jul 10 '24 09:07 prady0t

Added documentation fixes.

prady0t avatar Jul 14 '24 20:07 prady0t

This will need approval from @arjxn-py since he previously requested changes, we can merge after that

agriyakhetarpal avatar Jul 26 '24 17:07 agriyakhetarpal

No unnecessary logs this time around: https://github.com/pybamm-team/PyBaMM/actions/runs/10115401416/job/27976388229

agriyakhetarpal avatar Jul 26 '24 18:07 agriyakhetarpal

No unnecessary logs this time around: https://github.com/pybamm-team/PyBaMM/actions/runs/10115401416/job/27976388229

Noticed that, just that we'd need to update branch to merge. My bad, I should have done it earlier.

arjxn-py avatar Jul 26 '24 18:07 arjxn-py