PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Refactor test_experiment_step_termination.py***

Open abhicodes369 opened this issue 1 year ago • 3 comments

(from unit test to pytest)

Description

converted a unit test case that uses the unit test to pytest. On the official website of pybamm I saw that they are considering migrating from unit test to pytest.

abhicodes369 avatar Feb 04 '24 12:02 abhicodes369

Thanks for starting this @abhicodes369. It looks good, but ideally we want to do this after #3617, so I will let this sit for a while until that is complete and pytest is added to the codebase. If you're interested in contributing, please feel free to discuss something over there since multiple people can be assigned to that issue 🙂

agriyakhetarpal avatar Feb 04 '24 17:02 agriyakhetarpal

@abhicodes369, if you're interested, you can help drive #3857 to completion – or we can take this up again after it gets merged (should be about a week at most).

agriyakhetarpal avatar Mar 26 '24 14:03 agriyakhetarpal

I will look into it

abhicodes369 avatar Mar 26 '24 16:03 abhicodes369

@allcontributors please add @abhicodes369 for tests

agriyakhetarpal avatar May 31 '24 12:05 agriyakhetarpal

@agriyakhetarpal

I've put up a pull request to add @abhicodes369! :tada:

allcontributors[bot] avatar May 31 '24 12:05 allcontributors[bot]

Thanks, @abhicodes369!

agriyakhetarpal avatar May 31 '24 12:05 agriyakhetarpal

thanks @agriyakhetarpal it really means a lot

abhicodes369 avatar Jun 03 '24 14:06 abhicodes369