Add `max_step` arg in `basesolver`

[arjxn-py]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #2253

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• [x] New feature (non-breaking change which adds functionality)
• [ ] Optimization (back-end change that speeds up the code)
• [ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

• [x] No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• [x] All tests pass: $ python run-tests.py --all
• [x] The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

• [x] Code is commented, particularly in hard-to-understand areas
• [x] Tests added that prove fix is effective or that feature works

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.60%. Comparing base (4df6a87) to head (9e9bc12).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3106   +/-   ##
========================================
  Coverage    99.60%   99.60%           
========================================
  Files          259      259           
  Lines        21287    21309   +22     
========================================
+ Hits         21203    21225   +22     
  Misses          84       84           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[rtimms]

@arjxn-py are you still working on this?

[arjxn-py]

Yes, i'll try to finish this up asap. Apologies as this one went down in the stack, thanks for pinging.

[agriyakhetarpal]

It looks like Chocolatey community repositories are under maintenance, which explains the Windows job failures.

[arjxn-py]

@rtimms can you give me some input about setting max_step for drive cycle simulations to the step size in the data. Do I have to do something about that?

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[arjxn-py]

Should also do changelog for this, right?

[brosaplanella]

Should also do changelog for this, right?

Yup

[arjxn-py]

@rtimms I'd be happy to have your review & input on this. Thanks.