pywhy-graphs icon indicating copy to clipboard operation
pywhy-graphs copied to clipboard

Integration tests that run against the latest stable version of dodiscover

Open adam2392 opened this issue 2 years ago • 0 comments

Is your feature request related to a problem? Please describe. Causal graphs and their implementation inherently affect all upstream causal inference procedures. Most importantly dodiscover relies on the API of pywhy-graphs. Any changes introduced here should not break the "next version of dodiscover". In order to catch these, we need integration tests.

Describe the solution you'd like There are three options:

  1. integration tests in pywhy-graphs
  2. integration tests in dodiscover
  3. integration tests in both

I am leaning towards adding this to dodiscover only, or both. We can delete one of them down the line, but the CI times are already pretty fast, so we can sacrifice this for the sake of ensuring integrability across the two packages (and eventually dowhy).

The solution would just be to create a tight "accuracy" constraint on causal discovery algorithms that leverage each graph class and then this performance should not change across any changes done in pywhy_graphs.

adam2392 avatar Jan 05 '23 21:01 adam2392