python-coverage-comment-action icon indicating copy to clipboard operation
python-coverage-comment-action copied to clipboard

Images don't display in email notifications from Gmail

Open ewjoachim opened this issue 1 year ago • 9 comments

I wonder if there's something we can do so that notification emails are more readable. (this is from Gmail btw)

image

ewjoachim avatar Feb 27 '24 09:02 ewjoachim

Works on other clients. image

ewjoachim avatar Feb 27 '24 09:02 ewjoachim

I see the same issue using corporate gmail and Apple Mail

mbrisson-ivadolabs avatar May 06 '24 18:05 mbrisson-ivadolabs

Hm, so I think it's because svg is not supported in many email clients. Apparently, a simple change could be to switch from img.shields.io to raster.shields.io [edit] or changing .svg to .png[/]

Funnily enough, this could actually decrease the bandwith usage, as apparently on a few badges I've tried, the png is slightly smaller than the svg.

ewjoachim avatar May 07 '24 12:05 ewjoachim

Ok, apparently the .png provided by shields.io are the exact size of the badge is supposed to appear, so on screens with high pixel density the badge is very ugly. Until we find a way to fix this, I think I prefer the badge to appear right in github and not in gmail than ugly everywhere.

ewjoachim avatar May 26 '24 08:05 ewjoachim

I did some tests in #414 and nothing satisfactory was found. This stays an open problem. Anyone with an idea, feel free.

ewjoachim avatar Jun 27 '24 18:06 ewjoachim

Hm, alternative idea: embed the SVG. Does this work ?

ewjoachim avatar Jun 27 '24 19:06 ewjoachim

I use Gmail in Thunderbird, and it has the option to show remote images. In other words, these badges are not shown because they are on a remote server at https://camo.githubusercontent.com. I think so, you can use the data url and embed the image.

marcelotduarte avatar Dec 06 '24 21:12 marcelotduarte

The problem is that we need to find something that looks retina-ok in a markdown(GFM) comment body, so that when GitHub makes email out of it, it works. If you finds something that works, please tell me

ewjoachim avatar Dec 07 '24 08:12 ewjoachim