octo.nvim icon indicating copy to clipboard operation
octo.nvim copied to clipboard

FEATURE REQUEST: Show PR checks in PR pane

Open hahuang65 opened this issue 4 years ago • 5 comments

I'm curious if there's a way to show the PR checks in the PR view, without having to manually run :Octo pr checks.

If not, would this be a feasible, and reasonable feature request?

hahuang65 avatar Jul 23 '21 22:07 hahuang65

Its definitevely feasible, but if we place it below the metadata block, and there are many checks, they can take most of the visible lines. Even if the WebUI, they are shown in a different tab. Do you have any suggestions on mind?

pwntester avatar Jul 30 '21 21:07 pwntester

Sorry for the delayed response, been quite busy recently...

For me personally, we usually only have 2 checks, CI, and approval.

I'm not too sure of any great ideas to handle a large amount of checks.

Perhaps they can just be placed at the bottom of the buffer, like how it is in the PRs in the WebUI? Screen Shot 2021-08-10 at 10 08 14

hahuang65 avatar Aug 10 '21 17:08 hahuang65

This almost certainly would be handled as a separate feature request, but this would be a potential precursor to allowing admin override to merge when the checks conditions are not met.

image

losinggeneration avatar May 09 '22 18:05 losinggeneration

gh pr checks provides a summary before it displays info about the individual checks. For example:

  All checks were successful
  0 cancelled, 0 failing, 7 successful, 4 skipped, and 0 pending checks

What do you think about only displaying that in the PR pane? Or some prettier version of that with icons and highlights?

I'd be willing to take a shot at it when I have time if people think that's a good compromise. My team has 10+ pr checks, so I agree that listing them all would take up too much space. Unless we could have them folded on the initial render or something.

benelan avatar Nov 06 '23 05:11 benelan

My offer to implement this still stands but I created gh-fzf in the meantime, which as a run command.

Also related: #449

benelan avatar Jun 29 '24 00:06 benelan