ReactiveNetwork icon indicating copy to clipboard operation
ReactiveNetwork copied to clipboard

connection speed

Open eslam2010011 opened this issue 5 years ago • 5 comments

this library be from Facebook, can it be combined with your library to measure internet speed? Thank you

https://github.com/facebookarchive/network-connection-class

eslam2010011 avatar Apr 19 '20 18:04 eslam2010011

It can be combined with any library. It's developer choice how to perform an integration. In the case of the linked library, everything depends on what you want to achieve.

pwittchen avatar Apr 19 '20 19:04 pwittchen

Can you add it now, thank you

eslam2010011 avatar Apr 19 '20 19:04 eslam2010011

I don't want to add too many dependencies to this library. If you want to combine network-connection-class and ReactiveNetwork, then it should be done in your application. Moreover, I don't know what do you want to achieve, so even if I'd like to add new functionality to my library, I don't know your expectations.

pwittchen avatar Apr 19 '20 19:04 pwittchen

This helps a lot in making decisions, such as whether the internet is weak, it switches to offline mode, and when the internet is strong, it switches to online mode, not just knowledge, there is internet or not

eslam2010011 avatar Apr 20 '20 00:04 eslam2010011

I know, but this library has single responsibility. I don't want to put too many things in it. You can combine these two projects in your app by yourself if you need to.

pwittchen avatar Apr 22 '20 22:04 pwittchen