CommandClick icon indicating copy to clipboard operation
CommandClick copied to clipboard

versionCode decreased?

Open IzzySoft opened this issue 1 year ago • 4 comments

Looks like today's release got its versionCode messed up:

package: name='com.puutaro.commandclick' versionCode='14' versionName='1.1.14'

14 < 50, so no update – and downgrades are not allowed. I assume some typo happened, with 14 also being the "patch" part of versionname? Could you please fix?

Looking at the previous versions:

package: name='com.puutaro.commandclick' versionCode='53' versionName='0.0.53'
package: name='com.puutaro.commandclick' versionCode='50' versionName='0.0.50'

… seems to confirm something's wrong with the setup there.

    defaultConfig {
        applicationId = "com.puutaro.commandclick"
        minSdk = 27
        targetSdk = 33
        versionCode = 14
        versionName = "${versionMajor}.${versionMinor}.${versionCode}"

Oof. versionCode must ALWAYS be INCREASED – and can NEVER be DECREASED. Which is why my repo still shows v0.0.53 from September as latest version (all releases after that are considered "older" as they have a lower versionCode). Those having installed that (or any previous one) won't be able to update before you reach some x.x.54 with your current setup.

IzzySoft avatar Dec 03 '23 19:12 IzzySoft

Thank you for your pointing out!
I increment versionCode recreate release
By this, I think CommmandClick is satisfied with your and google's specificaton.

val versionMajor = 1
val versionMinor = 2
val versionPatch = 0
val versionCode = 54
.
.
.
defaultConfig {
        applicationId = "com.puutaro.commandclick"
        minSdk = 27
        targetSdk = 33
        versionCode = versionCode
.
.
.

puutaro avatar Dec 04 '23 02:12 puutaro

Well, but the APK seems a bit broken. From aapt d badging:

package: name='com.puutaro.commandclick' versionCode='' versionName='1.2.0' platformBuildVersionName='13' platformBuildVersionCode='33' compileSdkVersion='33' compileSdkVersionCodename='13'

No versionCode at all. No idea what went wrong there, but can you please check?

IzzySoft avatar Dec 04 '23 07:12 IzzySoft

Thank you.
I correct versionCode implementation.

Probably due to specifying versionCode by variable like bellow

 versionCode = versionCode

So correct bellow

 versionCode = 54

puutaro avatar Dec 04 '23 09:12 puutaro

That was what I thought as well. I'm no Android or Kotlin developer, so I don't know how to best use variables there. Though I had expected a build error should the assignment not be possible – especially as an APK without versionCode is not valid (unless Android uses some default if not specified). I've seen other projects using some settings.gradle for things like that – but as said, not being an Android/Kotlin developer I never checked how that works.

The new APK looks good so far, thanks! Except for VT, which shows a few false positives by "usual suspects" (Sangfor, TM HouseCall often have that).

IzzySoft avatar Dec 04 '23 11:12 IzzySoft