k8s-spot-termination-handler icon indicating copy to clipboard operation
k8s-spot-termination-handler copied to clipboard

add 'patch' verb to nodes resource in clusterrole to allow for node draining

Open metacyclic opened this issue 6 years ago • 1 comments

When draining a node from k8s, the first step is to patch the node spec and set node.Spec.Unschedulable=true. The current cluster role example doesn't include it, and it throws errors like shown in #7. Adding this verb does indeed fix the issue.

metacyclic avatar Jul 10 '19 15:07 metacyclic

Hi @metacyclic. Thanks for your PR.

I'm waiting for a pusher member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pusher-ci avatar Jul 10 '19 15:07 pusher-ci