ngx-fast-svg icon indicating copy to clipboard operation
ngx-fast-svg copied to clipboard

Demo not serving pre-rendered docs

Open ChristopherPHolder opened this issue 2 years ago • 2 comments

The live demo does not serve the pre-rendered version.

A potential cause is because it is redirecting in production:

Screenshot 2023-03-13 at 12 22 54

This means that when we try to access https://push-based.github.io/ngx-fast-svg/fast-svg?ls=distributed&list=1 We are redirected to from: https://push-based.github.io/ngx-fast-svg/fast-svg?ls=distributed&list=1 To: https://push-based.github.io/ngx-fast-svg/fast-svg/?ls=distributed&list=1

This means there is a unnecessary trailing slash with is directing to a page route which is not pre-rendered

/fast-svg/?ls=distributed&list=1 -> /fast-svg?ls=distributed&list=1

TODOS:

  • [ ] Remove trailing slash and redirection in prod

ChristopherPHolder avatar Mar 13 '23 11:03 ChristopherPHolder

Potentially relevant:

https://dev.to/ayyash/fixing-the-trailing-slash-in-static-site-generation-107k

ChristopherPHolder avatar Mar 13 '23 11:03 ChristopherPHolder

https://github.com/angular/angular/issues/16051#issuecomment-793005881

ChristopherPHolder avatar Mar 13 '23 12:03 ChristopherPHolder