purescript-foldable-traversable icon indicating copy to clipboard operation
purescript-foldable-traversable copied to clipboard

Published 20 hours ago • verified publisher icon purescript

Update instance names to match "ClassType" convention?

Open JordanMartinez opened this issue 4 years ago • 4 comments

See this comment in #131 for more details.

JordanMartinez avatar Feb 05 '21 02:02 JordanMartinez

With PureScript 0.14.2 being released with automatic instance naming, I suspect that this is not needed anymore. However, I think 5.x versions of this library should probably be compatible with all versions of 0.14.x including the ones before 0.14.2, so this change should be made when PureScript 0.15.0 is released.

triallax avatar Jul 03 '21 18:07 triallax

I'm not sure we should drop the instance names from core libraries. There's been a few issues that can arise with optional instance names when modules are being rebuilt. It might be safer to leave them in here.

JordanMartinez avatar Jul 03 '21 19:07 JordanMartinez

Good point; perhaps we should wait until all bugs related to that have been wrinkled out first.

triallax avatar Jul 03 '21 20:07 triallax

I don’t think we have any known bugs like that right now, but for me the reason to avoid this for the time being is that it would mean dropping support for earlier compiler versions, which we usually treat as a breaking change.

hdgarrood avatar Jul 03 '21 21:07 hdgarrood