Convert the Legacy Puppet functions to the Modern format

[david22swan]

Since the release of the Modern Puppet function format several of the functions and all new ones to be added have been written in it, however the vast majority of the original functions remain in the Legacy format.

While they are still functional and will not currently cause any errors in their use, they are still outdated and using a format that has been fazed out, potential causing potential problems down the line.

As such it would be best to update them now before any issues can arise.

[b4ldr]

What's your view on if they should be name spaced with stdlib::. My personal view is that stdlib is a bit more special and unique then most modules as such we could drop the requirement to namespace all (new or refactored) functions

[ekohl]

Somehow this doesn't link back to https://github.com/puppetlabs/puppetlabs-stdlib/pull/1259 but that's where this came up. In https://github.com/puppetlabs/puppetlabs-stdlib/pull/1259#issuecomment-1197839997 I stated pretty much the same as @b4ldr that I do feel stdlib is special and can be in the global namespace.

[github-actions[bot]]

Hello! 👋

This issue has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which issues need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the issue with a comment.

[alexjfisher]

This still needs doing...