Add a flag to disable read_database

[ardichoke]

I'm currently in the process of deploying standalone puppetdb hosts, which connect to a managed database on a cloud provider. The entire read_database section caused me a large amount of unnecessary confusion and are simply unnecessary when not running a hot standby cluster. This adds a simple flag to turn read_database config off. Defaults the setting to true in params in order to not change default functionality.

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder[bot]]

puppetdb is a class

Breaking changes to this file WILL impact these 6 modules (exact match):

• neillturner-foreman_puppetdb
• aursu-puppet
• ploperations-puppet
• puppetfinland-puppetmaster
• simp-simp
• abstractit-puppet

Breaking changes to this file MAY impact these 2 modules (near match):

• example42-psick
• devopera-dopuppetmaster

puppetdb::params is a class

that may have no external impact to Forge modules.

puppetdb::server is a class

that may have no external impact to Forge modules.

This module is declared in 33 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[ardichoke]

Don't want to be a nag, but this has been approved since February, can this get merged?

[ardichoke]

Anyone? Bueller?

[smortex]

Why has the test suite not run against this PR? Closing and re-opening to see if it helps…

[smortex]

Does not seems to help. Can you please rebase your changes on top of the main branch?

From your branch in your fork of the repo:

git fetch origin       # Download the latest code we have here
git rebase origin/main # Move your commits on top of the main branch
git push -f            # Send the changes (-f is required because we re-wrote history)

[ardichoke]

Rebased... as requested. Still doesn't seem to be running the test suite. I have to imagine because this PR predates the test suite but no one ever bothered merging it.

[h0tw1r3]

@ardichoke recently the test suite was overhauled. Can you rebase please? I expect there will be some work to fix the conflicts and update the spec tests. If you need assistance with updating the tests, happy to help.

[ardichoke]

I'm dropping this.... it has been 2 years since I authored this simple change and no one has bothered to merge it. I'm not wasting even more of my personal time sorting out 2 years worth of merge conflicts when it will likely languish even longer thanks to the neglect of Perforce.