Module is broken due to $::is_pe on puppet opensource

[juanbrein]

When trying to use this module it complains due to not being able to install pe-puppetdb and pe-puppetdb-terminus.

I think the problem is this line in params.pp:

  if $::is_pe {

The problem as far as I can see is that $::is_pe is not a bool but a string.

Possible fix would be something like:

if $::is_pe == 'true' {

But might be that is better to change the fact and make it return bool which is in stdlib

[juanbrein]

Please verify this test:

  $type = type($::is_pe)

  notify {"is_pe is: ${type} and value is: ${::is_pe}":}

outputs:

Notice: /Stage[main]/Puppetdb::Params/Notify[is_pe is: string and value is: false]/message: defined 'message' as 'is_pe is: string and value is: false'

[juanbrein]

As far as I found this is directly related to:

https://tickets.puppetlabs.com/browse/FACT-151

[kbarber]

Yeah, its a string not a boolean. Well spotted @juanbrein. Fixed.

[bschonec]

If this is fixed, can the issue be close as well?