puppetlabs-mysql
puppetlabs-mysql copied to clipboard
Add support for ALL grant on mysql >= 8.0.33
Summary
This patch add ALL grant support for mysql >= 8.0.33, due tot the recent addition of the new TELEMETRY_LOG_ADMIN, see: https://docs.oracle.com/cd/E17952_01/mysql-8.0-relnotes-en/news-8-0-33.html#mysqld-8-0-33-feature
Additional Context
Add any additional context about the problem here.
- [x] Root cause and the steps to reproduce. (If applicable)
Puppet changes grant at each run:
Notice: /Stage[main]/Mysql::Server::Providers/Mysql_grant[XXX@YYY/*.*]/privileges: privileges changed ['ALL', 'APPLICATION_PASSWORD_ADMIN', 'AUDIT_ABORT_EXEMPT', 'AUDIT_ADMIN', 'AUTHENTICATION_POLICY_ADMIN', 'BACKUP_ADMIN', 'BINLOG_ADMIN', 'BINLOG_ENCRYPTION_ADMIN', 'CLONE_ADMIN', 'CONNECTION_ADMIN', 'ENCRYPTION_KEY_ADMIN', 'FIREWALL_EXEMPT', 'FLUSH_OPTIMIZER_COSTS', 'FLUSH_STATUS', 'FLUSH_TABLES', 'FLUSH_USER_RESOURCES', 'GROUP_REPLICATION_ADMIN', 'GROUP_REPLICATION_STREAM', 'INNODB_REDO_LOG_ARCHIVE', 'INNODB_REDO_LOG_ENABLE', 'PASSWORDLESS_USER_ADMIN', 'PERSIST_RO_VARIABLES_ADMIN', 'REPLICATION_APPLIER', 'REPLICATION_SLAVE_ADMIN', 'RESOURCE_GROUP_ADMIN', 'RESOURCE_GROUP_USER', 'ROLE_ADMIN', 'SENSITIVE_VARIABLES_OBSERVER', 'SERVICE_CONNECTION_ADMIN', 'SESSION_VARIABLES_ADMIN', 'SET_USER_ID', 'SHOW_ROUTINE', 'SYSTEM_USER', 'SYSTEM_VARIABLES_ADMIN', 'TABLE_ENCRYPTION_ADMIN', 'TELEMETRY_LOG_ADMIN', 'XA_RECOVER_ADMIN'] to ['ALL'] (corrective)
- [x] Thought process behind the implementation.
Add the new TELEMETRY_LOG_ADMIN, according to previous code.
Related Issues (if any)
Issue #1474 #1502 #1503
Checklist
- [ ] 🟢 Spec tests.
- [ ] 🟢 Acceptance tests.
- [X] Manually verified. (For example
puppet apply)
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.
:white_check_mark: Marc-DRI
:white_check_mark: alaunay
:white_check_mark: BuJo
:x: rahuls2997
You have signed the CLA already but the status is still pending? Let us recheck it.
So much looking forward to this! (FWIW, this is also causing issues when performing long-running schema changes.)
@Ramesh7, maybe if you find some time, would you have a look at this please? Thanks :)
Any progress in reviewing that PR?
ping @puppetlabs
Would be good to have an eta for this. Although can easily ignore it's a pain when developing and seeing constant changes
Maybe @alexjfisher or @bastelfreak ? Been a few months 😅
@ianc769 can you please rebase against main to get rid of the merge commit?
I probably borked the branch, here's the patch, it'll be easier.
(renamed it to .txt, it didn't like a .patch...)
any progress on this PR, seems to have been forgotten about?
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 4 committers have signed the CLA.✅ alaunay✅ Marc-DRI✅ BuJo❌ rahuls2997You have signed the CLA already but the status is still pending? Let us recheck it.
Is the cla, required to progress?
Given how perforce treats the community since half a year, I recommend to not sign the CLA (https://www.puppet.com/blog/open-source-puppet-updates-2025).