puppetlabs-firewall icon indicating copy to clipboard operation
puppetlabs-firewall copied to clipboard

update regex to allow underscores in firewall name

Open dlware opened this issue 2 years ago • 3 comments

Closing Issue #1173

Summary

Updated regex for firewall name to allow the use of underscores. lib/puppet/type/firewall.rb:136 used puppet strings to update REFERENCE.md

Additional Context

Underscores are supported by the underlying applications and in wide use.

Related Issues (if any)

Issue #1173

Checklist

  • [x] 🟢 Spec tests.
  • [x] 🟢 Acceptance tests.
  • [x] Manually verified. (For example puppet apply)

dlware avatar Nov 02 '23 15:11 dlware

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 02 '23 15:11 CLAassistant

Hello All,

Any update on this? Seems like a very simple change.

Thanks,

dlware

dlware avatar Mar 06 '24 15:03 dlware

Up! Any news?

deemon87 avatar Jul 23 '24 12:07 deemon87