puppetlabs-apache icon indicating copy to clipboard operation
puppetlabs-apache copied to clipboard

Published 20 hours ago • verified publisher icon puppetlabs

Enable support for svn_parent_path in vhost directories

Open deepak7340 opened this issue 1 year ago • 3 comments

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • [ ] Root cause and the steps to reproduce. (If applicable)
  • [ ] Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • [ ] 🟢 Spec tests.
  • [ ] 🟢 Acceptance tests.
  • [ ] Manually verified. (For example puppet apply)

deepak7340 avatar Dec 12 '23 09:12 deepak7340

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 12 '23 09:12 CLAassistant

Hi team can you please review this ?

deepak7340 avatar Dec 28 '23 12:12 deepak7340

Can you please adjust the test suite so that this is tested? These hashes are currently free-form which allow you to add a new item with minimal effort but at the cost of being super fragile because a typo would not be catch…

At some point, we will probably add data types to constraint what can be passed, but without tests this will make this needed step more stressful.

Thanks!

smortex avatar Dec 29 '23 02:12 smortex