puppetlabs-image_build icon indicating copy to clipboard operation
puppetlabs-image_build copied to clipboard

Published 20 hours ago • verified publisher icon puppetlabs-toy-chest

Updating Dockerfile template to use same factfile name as supplied

Open avidspartan1 opened this issue 6 years ago • 1 comments

This allows the use of structured fact overrides. When we always copy the custom facts file as "custom_facts.txt", it limits us to only string-based facts. When we allow things like .yaml or .json, we can introduce structured fact overrides since we will be placing the file as whatever format the user is feeding in. I think this is more intuitive and makes this tool more powerful.

avidspartan1 avatar Jan 18 '19 15:01 avidspartan1

Coverage Status

Coverage remained the same at 93.0% when pulling a487a4fb735c48815371e77f31dd818d3341677f on avidspartan1:master into 419fe403cfe712dcb411c4d6674586f1d857c1b5 on puppetlabs:master.

coveralls avatar Jan 18 '19 15:01 coveralls