puppeteer icon indicating copy to clipboard operation
puppeteer copied to clipboard

Update `waitForNetworkIdle()` docblock

Open bert-w opened this issue 3 years ago • 2 comments

Summary Documentation update for page.waitForNetworkIdle(). The original documentation did not mention anything about a failing promise, and if/how that would ever happen.

bert-w avatar Aug 08 '22 16:08 bert-w

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

@jrandolf could you please include this change into one of your documentation changes? I think we can improve this part of the docs but we actually need to document the options inline and have @defaultValue for default values etc.

OrKoN avatar Aug 11 '22 06:08 OrKoN

Closed due to lack of activity.

OrKoN avatar Dec 12 '22 10:12 OrKoN