pulumi icon indicating copy to clipboard operation
pulumi copied to clipboard

Fix: Class function serialization bug (NodeJS)

Open thehenrymcintosh opened this issue 7 months ago • 15 comments

Fixes point two from this issue.

Minified inline class syntax leads to a serialisation error, despite being valid Javascript.

thehenrymcintosh avatar Apr 25 '25 15:04 thehenrymcintosh

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

github-actions[bot] avatar Apr 25 '25 15:04 github-actions[bot]

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

github-actions[bot] avatar Apr 28 '25 13:04 github-actions[bot]

/run-acceptance-tests Please view the results of the acceptance tests Here

brandonpollack23 avatar Apr 29 '25 04:04 brandonpollack23

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

github-actions[bot] avatar Apr 29 '25 08:04 github-actions[bot]

Thanks @brandonpollack23 ! It's also my first contribution to the project, so I'd appreciate any feedback or guidance to make sure the change is correct and meets the guidelines.

thehenrymcintosh avatar Apr 29 '25 23:04 thehenrymcintosh

Thanks for the PR @thehenrymcintosh!

We are also being impacted by the same issue. Would love to see this merged soon, if possible? 🙏 Thanks @brandonpollack23 @Frassle

luismfonseca avatar May 02 '25 15:05 luismfonseca

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

github-actions[bot] avatar May 11 '25 18:05 github-actions[bot]

@lunaris thank you for the feedback! I've implemented all of your points, lmk if there's anything else 🙂

thehenrymcintosh avatar May 11 '25 18:05 thehenrymcintosh

Hi @lunaris, is there anything else that needs doing on this?

thehenrymcintosh avatar May 20 '25 18:05 thehenrymcintosh

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

github-actions[bot] avatar May 28 '25 22:05 github-actions[bot]

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

github-actions[bot] avatar May 28 '25 22:05 github-actions[bot]

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

github-actions[bot] avatar May 28 '25 22:05 github-actions[bot]

/run-acceptance-tests Please view the results of the acceptance tests Here

lunaris avatar Jun 02 '25 13:06 lunaris

/run-acceptance-tests Please view the results of the acceptance tests Here

lunaris avatar Jun 05 '25 13:06 lunaris

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

github-actions[bot] avatar Jun 05 '25 13:06 github-actions[bot]

@lunaris just checking in on this because it's been a while - anything I need to do to get this merged?

thehenrymcintosh avatar Aug 21 '25 07:08 thehenrymcintosh

/rebase

julienp avatar Aug 21 '25 09:08 julienp

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

github-actions[bot] avatar Aug 21 '25 09:08 github-actions[bot]

Sorry, I think this was meant to be merged but somehow CI didn't. It's on its way now. Thank you!

julienp avatar Aug 21 '25 09:08 julienp

This PR has been shipped in release v3.192.0.

pulumi-bot avatar Sep 02 '25 18:09 pulumi-bot