pulumi
pulumi copied to clipboard
Fix: Class function serialization bug (NodeJS)
Fixes point two from this issue.
Minified inline class syntax leads to a serialisation error, despite being valid Javascript.
PR is now waiting for a maintainer to take action.
Note for the maintainer: Commands available:
/run-acceptance-tests- used to test run the acceptance tests for the project/run-codegen- used to test the Pull Request against downstream codegen/run-docs-gen- used to test the Pull Request against documentation generation
PR is now waiting for a maintainer to take action.
Note for the maintainer: Commands available:
/run-acceptance-tests- used to test run the acceptance tests for the project/run-codegen- used to test the Pull Request against downstream codegen/run-docs-gen- used to test the Pull Request against documentation generation
/run-acceptance-tests Please view the results of the acceptance tests Here
PR is now waiting for a maintainer to take action.
Note for the maintainer: Commands available:
/run-acceptance-tests- used to test run the acceptance tests for the project/run-codegen- used to test the Pull Request against downstream codegen/run-docs-gen- used to test the Pull Request against documentation generation
Thanks @brandonpollack23 ! It's also my first contribution to the project, so I'd appreciate any feedback or guidance to make sure the change is correct and meets the guidelines.
Thanks for the PR @thehenrymcintosh!
We are also being impacted by the same issue. Would love to see this merged soon, if possible? 🙏 Thanks @brandonpollack23 @Frassle
PR is now waiting for a maintainer to take action.
Note for the maintainer: Commands available:
/run-acceptance-tests- used to test run the acceptance tests for the project/run-codegen- used to test the Pull Request against downstream codegen/run-docs-gen- used to test the Pull Request against documentation generation
@lunaris thank you for the feedback! I've implemented all of your points, lmk if there's anything else 🙂
Hi @lunaris, is there anything else that needs doing on this?
PR is now waiting for a maintainer to take action.
Note for the maintainer: Commands available:
/run-acceptance-tests- used to test run the acceptance tests for the project/run-codegen- used to test the Pull Request against downstream codegen/run-docs-gen- used to test the Pull Request against documentation generation
PR is now waiting for a maintainer to take action.
Note for the maintainer: Commands available:
/run-acceptance-tests- used to test run the acceptance tests for the project/run-codegen- used to test the Pull Request against downstream codegen/run-docs-gen- used to test the Pull Request against documentation generation
PR is now waiting for a maintainer to take action.
Note for the maintainer: Commands available:
/run-acceptance-tests- used to test run the acceptance tests for the project/run-codegen- used to test the Pull Request against downstream codegen/run-docs-gen- used to test the Pull Request against documentation generation
/run-acceptance-tests Please view the results of the acceptance tests Here
/run-acceptance-tests Please view the results of the acceptance tests Here
PR is now waiting for a maintainer to take action.
Note for the maintainer: Commands available:
/run-acceptance-tests- used to test run the acceptance tests for the project/run-codegen- used to test the Pull Request against downstream codegen/run-docs-gen- used to test the Pull Request against documentation generation
@lunaris just checking in on this because it's been a while - anything I need to do to get this merged?
/rebase
PR is now waiting for a maintainer to take action.
Note for the maintainer: Commands available:
/run-acceptance-tests- used to test run the acceptance tests for the project/run-codegen- used to test the Pull Request against downstream codegen/run-docs-gen- used to test the Pull Request against documentation generation
Sorry, I think this was meant to be merged but somehow CI didn't. It's on its way now. Thank you!
This PR has been shipped in release v3.192.0.