pulumi-kubernetes icon indicating copy to clipboard operation
pulumi-kubernetes copied to clipboard

[WIP] Fix SSA conflict when updating old objects

Open blampe opened this issue 1 year ago • 2 comments

Refs https://github.com/pulumi/customer-support/issues/1837

This adds unit tests around:

  • SSA updates for objects with existing field managers.
  • SSA updates for old/legacy objects with no field managers.

This currently forces the apply when the object has no managers. There's also some code showing where we could impersonate kubectl SSA to trigger a server-side upgrade of these fields.

Worth noting client-go recently added support for Apply but only in typed clients. I use a wrapper around this to test our untyped ssaUpdate path.

blampe avatar Oct 19 '24 00:10 blampe

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

github-actions[bot] avatar Oct 22 '24 17:10 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.04%. Comparing base (087d29e) to head (82d937f). Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3275      +/-   ##
==========================================
+ Coverage   40.64%   41.04%   +0.39%     
==========================================
  Files          84       84              
  Lines       12716    12719       +3     
==========================================
+ Hits         5169     5220      +51     
+ Misses       7163     7113      -50     
- Partials      384      386       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 22 '24 17:10 codecov[bot]

This PR has been shipped in release v4.18.3.

pulumi-bot avatar Nov 04 '24 16:11 pulumi-bot