pulumi-kubernetes icon indicating copy to clipboard operation
pulumi-kubernetes copied to clipboard

Helm resource integer values cannot be set as string

Open eljoth opened this issue 4 years ago • 1 comments

Setting resource limits as string which are defined in the values as int, cannot be set.

Expected behavior

Resource limits can be set as string as well to allow less than 1 CPU to be set as limit e.g.

Current behavior

Placing a string in a value for a resource which defaults to an int in the values.yaml, leads to an error:

grafik

Values.yaml section: https://github.com/scylladb/scylla-operator/blob/6ff5d1a5530d657512d8f70daa425cf0025cb77d/helm/scylla/values.yaml#L48-L66

eljoth avatar Mar 17 '21 06:03 eljoth

Although I believe this not really a bug, I think, this should be fixed because (many?) helm charts exist, that are not using units for their cpu resource quotas.

Just for reference: https://github.com/scylladb/scylla-operator/issues/505

eljoth avatar Mar 17 '21 08:03 eljoth

The issue was due to an upstream bug in the scylla chart's schema; cpu was modeled as an integer. https://github.com/scylladb/scylla-operator/blob/42a0f1e3df9843066296a14a83c9add6cb48434b/helm/scylla/values.schema.json#L128-L130

Was fixed: https://github.com/scylladb/scylla-operator/commit/58ec5852e98bf85f57fcfeb5b59d6391acd61ddb

EronWright avatar Apr 01 '24 22:04 EronWright