pulumi-kubernetes-operator
pulumi-kubernetes-operator copied to clipboard
prometheus monitoring fix - missing label
Issue description
Pulumi kubernetes operator creates Service and ServiceMonitor objects for metrics by itself: https://github.com/pulumi/pulumi-kubernetes-operator/blob/7d9e693bc6e27f1e3881ce350cdf7fbde71b26be/cmd/manager/main.go#L186C31-L186C31
Service created for metrics requires name label added on pods.
Proposed changes
Added "name" label with {{ template "pulumi-kubernetes-operator.name" . }} value to pulumi-kubernetes-operator Deployment at ReplicaSet level.
impact/no-changelog-required
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR
@dirien done
Hey @Kris686,
thanks for the PR. Can you bump the minor version in the
Chart.yamland addartifacthub.io/changes:text?
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR
This PR has been shipped in release v2.0.0.