pulumi-kubernetes-operator icon indicating copy to clipboard operation
pulumi-kubernetes-operator copied to clipboard

prometheus monitoring fix - missing label

Open Kris686 opened this issue 2 years ago • 4 comments

Issue description

Pulumi kubernetes operator creates Service and ServiceMonitor objects for metrics by itself: https://github.com/pulumi/pulumi-kubernetes-operator/blob/7d9e693bc6e27f1e3881ce350cdf7fbde71b26be/cmd/manager/main.go#L186C31-L186C31

Service created for metrics requires name label added on pods.

Proposed changes

Added "name" label with {{ template "pulumi-kubernetes-operator.name" . }} value to pulumi-kubernetes-operator Deployment at ReplicaSet level.

impact/no-changelog-required

Kris686 avatar Nov 09 '23 09:11 Kris686

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] avatar Nov 09 '23 09:11 github-actions[bot]

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] avatar Nov 13 '23 10:11 github-actions[bot]

@dirien done

Hey @Kris686,

thanks for the PR. Can you bump the minor version in the Chart.yaml and add artifacthub.io/changes: text?

Kris686 avatar Nov 13 '23 10:11 Kris686

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] avatar Nov 13 '23 10:11 github-actions[bot]

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] avatar Apr 19 '24 13:04 github-actions[bot]

This PR has been shipped in release v2.0.0.

pulumi-bot avatar Feb 19 '25 17:02 pulumi-bot