pulumi-eks icon indicating copy to clipboard operation
pulumi-eks copied to clipboard

Replace tslint with eslint and fix a missing interpolate

Open blampe opened this issue 5 months ago • 2 comments

In https://github.com/pulumi/pulumi-eks/issues/1799 a user reported an error message surfacing from TS which indicated a missing interpolation.

I wanted to use https://github.com/pulumi/eslint-plugin-pulumi to track down the source of the problem, but this repo is still using (deprecated) TSLint.

So I upgraded us to eslint and dropped in the pulumi plugin, which immediately identified a problem with our invalid subnets error.

Fixes https://github.com/pulumi/pulumi-eks/issues/1799.

blampe avatar Jun 20 '25 18:06 blampe

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

github-actions[bot] avatar Jun 20 '25 18:06 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 0.00%. Comparing base (f46b7a3) to head (e5bdd26). :warning: Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1803   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           1       1           
  Lines        2804    2804           
======================================
  Misses       2804    2804           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 20 '25 18:06 codecov[bot]

This PR has been shipped in release v4.0.1.

pulumi-bot avatar Jul 30 '25 20:07 pulumi-bot

This PR has been shipped in release v4.0.1.

pulumi-bot avatar Jul 30 '25 20:07 pulumi-bot

This PR has been shipped in release v4.0.1.

pulumi-bot avatar Jul 30 '25 20:07 pulumi-bot

This PR has been shipped in release v4.0.1.

pulumi-bot avatar Jul 30 '25 20:07 pulumi-bot