pulumi-eks
pulumi-eks copied to clipboard
Replace tslint with eslint and fix a missing interpolate
In https://github.com/pulumi/pulumi-eks/issues/1799 a user reported an error message surfacing from TS which indicated a missing interpolation.
I wanted to use https://github.com/pulumi/eslint-plugin-pulumi to track down the source of the problem, but this repo is still using (deprecated) TSLint.
So I upgraded us to eslint and dropped in the pulumi plugin, which immediately identified a problem with our invalid subnets error.
Fixes https://github.com/pulumi/pulumi-eks/issues/1799.
Does the PR have any schema changes?
Looking good! No breaking changes found. No new resources/functions.
Maintainer note: consult the runbook for dealing with any breaking changes.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 0.00%. Comparing base (f46b7a3) to head (e5bdd26).
:warning: Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1803 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 2804 2804
======================================
Misses 2804 2804
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
This PR has been shipped in release v4.0.1.
This PR has been shipped in release v4.0.1.
This PR has been shipped in release v4.0.1.
This PR has been shipped in release v4.0.1.