pulumi-eks
pulumi-eks copied to clipboard
pulumi
Managed Node Group Launch Template Improvements
Proposed changes
Add the ability to specify gpu/amiId/amiType on a managed node group, and specify disk size when a launch template is created.
This PR is a draft because I haven't been able to test the changes (yet) - any guidance on this is helpful, I don't have easy access to a spare AWS account where I can spin up test clusters.
Related issues (optional)
Resolves #1224
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks for contributing here! We indeed rely heavily on integration-level tests so an AWS testing account is needed to test the changes.
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR
Yep @t0yv0 - Is testing something you're prepared to help with? I do have access to my company's AWS account, but spinning up cluster(s) is a pretty heavy operation so would love to avoid if possible.
@JustASquid I can help with testing this. Do you want to have a first stab at creating a test?
Cheers @flostadler - I just went on leave, should be able to take a stab at writing some tests in a couple weeks. Appreciate the help and guidance.
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR
@flostadler - I added the SDK generation and took a crack at adding some tests - surely they are missing something but hopefully it's a jumping off point.
Thanks a lot @JustASquid! I left some comments, let me know if you need some help with any of the proposed changes
@JustASquid I'm starting to touch the same parts of the code base as part of refactoring needed for https://github.com/pulumi/pulumi-eks/issues/1195. I'd propose that I fold your changes into that to prevent duplication/conflicts. What do you think about that?
Closing this in favor of https://github.com/pulumi/pulumi-eks/issues/1195.