pulumi-eks icon indicating copy to clipboard operation
pulumi-eks copied to clipboard

Published 20 hours ago • verified publisher icon pulumi

Add Addon resource to EKS provider

Open rquitales opened this issue 1 year ago • 2 comments

Proposed Changes

In late 2020, AWS introduced EKS managed addons, which allow AWS to handle the management of cluster addons as part of the EKS lifecycle. This pull request integrates the upstream aws.eks.addon resource into our EKS provider, enhancing visibility and management of this resource.

By incorporating this resource, users will be able to manage addons such as coredns and kube-proxy, along with other supported addons. We chose not to create specific Pulumi resources for each addon, as doing so and exposing schema configurations as resource properties could be fragile with future schema changes. Additionally, user requests to create CoreDNS and kube-proxy resources were proposed before AWS managed addons were available, when self-management was necessary to keep these components up to date. VpcCni is another example of an addon that we also intend to transition to AWS management.

Testing:

  • Conducted manual testing to verify the successful installation and upgrade of new addons within a cluster
  • Updated existing TypeScript and MLC (Python) tests to include the installation of coredns as an addon

Related issues (optional)

Closes: #587 Closes: #253

rquitales avatar May 16 '24 23:05 rquitales

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • index.Addon

github-actions[bot] avatar May 17 '24 21:05 github-actions[bot]

Tests are failing due to orphaned AWS resources. Will need to run the cleanup script before re-running the test suite.

rquitales avatar May 17 '24 22:05 rquitales

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • index.Addon

github-actions[bot] avatar Jun 03 '24 23:06 github-actions[bot]

Quick question about these addons.

We have some related code in pulumi-aws:

https://github.com/pulumi/pulumi-aws/issues/3009 https://github.com/pulumi/pulumi-aws/issues/2720 https://github.com/pulumi/pulumi-aws/issues/2732

Does this change look good in light of this code? Does it interact with defaultAddonsToRemove or should it? Thanks.

t0yv0 avatar Jun 04 '24 17:06 t0yv0

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • index.Addon

github-actions[bot] avatar Jun 04 '24 22:06 github-actions[bot]