pulumi-azure-native
pulumi-azure-native copied to clipboard
Fix regression about field case conversion in ManagedCluster.autoScalerProfile
This is an attempt to fix a regression in the ManagedCluster resource.
For ManagedCluster.autoScalerProfile, the Azure API expect keys to be formatted in kebab-case instead of camelCase. Refer to the issue marked below to see the steps to reproduce this failure.
This only target fields nested under ManagedCluster.autoScalerProfile, the rest is fine.
Obviously it's concerning that Azure doesn't agree on a convention so I suppose this is an exception?
I'm still getting familiar with the codebase, so please correct me if this isn't the right place for exceptions. It feels like a workaround, and I'm wondering if there is a more appropriate place to manage these per-resource exceptions.
Also, here I'm using a mapping but maybe we could just do a simple conversion instead, any keys under autoScalerProfile will be converted to kebab-case, what's your opinion on this?
Fix: https://github.com/pulumi/pulumi-azure-native/issues/4388
Hi there 👋 Thank you for submitting a pull request.
Acceptance tests must be run by a maintainer. If a maintainer hasn't picked this up after 7 days, please do reach out to a maintainer via our community Slack.
Maintainers: Please review changes then run tests by adding the comment:
/run-acceptance-tests
Thanks @etiennetremel, taking a look.
Thanks @etiennetremel for the issue report and the suggested fix! Your fix would be fine, but it turns out it can be fixed in a more general way: https://github.com/pulumi/pulumi-azure-native/pull/4455