pulumi-azure-native
pulumi-azure-native copied to clipboard
Remove legacy auth code
Authentication was updated to use azidentity in release v2.69 in October 2024. There are no open issues that require users to fall back to the previous auth stack. Therefore, we should remove the legacy auth which would be a significant simplification of the provider code.
Requirements:
- Issue warning if the following environment is specified, because it isn't supported:
AZURESTACKCLOUD - official vars: https://github.com/Azure/azure-sdk/blob/main/_includes/tables/environment_variables.md
- correct handling of
AZUREUSGOVERNMENTvsAZUREUSGOVERNMENTCLOUD - support for AZURE_CLOUD (ref)
- invoke:get-client-token
- invoke:get-client-config
- token caching (safely)
- update: https://www.pulumi.com/docs/intro/cloud-providers/azure/setup/#service-principal-authentication
- docs: recommend that subscription id be set
- behavior when cli isn't installed
- cli mode when a service principal is active (doc link)
- environment "mismatch" detection, or how to use CLI auth with cloud argument
- Add Florian Stadler as reviewer
- Note: "AZ CLOUD CLI" environment is a service principal environment
- AZURE_ENVIRONMENT of
AzureCloudandAzurePublicCloud(https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/cloud.py#L352) - Tests for GetClientConfig
- msgraph cloud endpoints
References:
- https://github.com/microsoftgraph/msgraph-sdk-go/issues/235
- old config: https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/previous-versions-quickstart.md
A PR to cleanly separate the old/new code: https://github.com/pulumi/pulumi-azure-native/pull/4242
Status update: https://github.com/pulumi/pulumi-azure-native/pull/4242 completed the transition to the new azidentity-based system, to be released while leaving the legacy option in place. After some time, we expect to merge https://github.com/pulumi/pulumi-azure-native/pull/4284 to remove the legacy option completely.