pulumi-azure-native
pulumi-azure-native copied to clipboard
Remove pulumictl and java-gen
Stacked on #3775
- Use java plugin bundled with the Pulumi CLI via
pulumi package gen-sdkcommand. - Insert the real version into the generated
build.gradleto match other SDKs.
Comparing all non-committed files locally, the only difference is the "generated by" header comment changing from "java-gen" to "pulumi".
It appears that the only way to configure the java gen to include the gradle setup is by adding two fields to the java lanaguge config in the schema.
Depended on https://github.com/pulumi/pulumi-java/pull/1501 being released as part of the Pulumi CLI which is now complete in 3.143.0
Does the PR have any schema changes?
Looking good! No breaking changes found. No new resources/functions.
Not super sure. Wonder which version of the javagen code the new invocation is calling, though sounds like that code is present on latest.
Looks like pu/pu is importing github.com/pulumi/pulumi-java/pkg v0.18.0
This should be shippable once the pulumi-java then pulumi (with the upgraded dependency) are released.
This is still failing due to:
- https://github.com/pulumi/pulumi-java/issues/1508
This is still failing due to:
@danielrbradley the issue was fixed and shipped p-java v1.0.0.
Yup, hoping to get time to finish this up soon
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 56.97%. Comparing base (
54a828d) to head (516e33a).
Additional details and impacted files
@@ Coverage Diff @@
## master #3776 +/- ##
==========================================
+ Coverage 56.96% 56.97% +0.01%
==========================================
Files 79 79
Lines 12407 12410 +3
==========================================
+ Hits 7068 7071 +3
Misses 4809 4809
Partials 530 530
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@thomas11, @t0yv0 & @lunaris I think this is very close to working via the plugin now with a couple of parts to confirm:
- It appears we need to set the
buildFilesandgradleNexusPublishPluginVersionoptions in the schema java lanuage config - can't see any other way to enable this. Perhaps we could just set this as the default now? Or alternatively have a simpler single field to specify the build setup to also help with if we move to the maven plugin? - The dependency on
com.pulumi:pulumiin the build.gradle is generated as0.19.0whereas the gen binary generated it at1.0.0. Does something need bumping to move the plugin version to use 1.0.0 or is this correct?