pulumi-az-pipelines-task icon indicating copy to clipboard operation
pulumi-az-pipelines-task copied to clipboard

Support comments

Open jaxxstorm opened this issue 3 years ago • 6 comments

Is your feature request related to a problem? Please describe. A customer has created a custom integration that will comment back on the ADO task output to show what is changing, very similar to the github action integration

Describe the solution you'd like When Pulumi preview or up runs, any changes should be posted back to the PR or the triggering pipeline

Describe alternatives you've considered Similar to GitHub actions

jaxxstorm avatar Aug 18 '22 17:08 jaxxstorm

This seems to be the same as #87

jaxxstorm avatar Aug 18 '22 17:08 jaxxstorm

Cannot close issue without required labels: kind/, resolution/

pulumi-bot avatar Aug 18 '22 17:08 pulumi-bot

This should be possible using the DevOps REST API to create comment threads in PRs. There's a Node.js client SDK for interacting with the API.

Additional refs

https://docs.microsoft.com/en-us/rest/api/azure/devops/git/pull-request-threads/create?view=azure-devops-rest-6.0&tabs=HTTP

https://docs.microsoft.com/en-us/rest/api/azure/devops/git/pull-request-thread-comments/create?view=azure-devops-rest-6.0&tabs=HTTP

praneetloke avatar Sep 07 '22 21:09 praneetloke

would this help? https://marketplace.visualstudio.com/items?itemName=tylermurry.pr-auto-comment If the pulumi task outputs the result in json file or something

sloncho avatar Sep 19 '22 11:09 sloncho

Would it be possible to skip the deletion of the temporary pulumi-out.log file or make deleting it configurable? If I could grab that file I could pipe its contents into the github comment task or use it for other purposes. This would be very helpful especially since the Pulumi GitHub App is not working!

Specifically, removing or making optional line 175 of pulumi.ts

dblair-cet avatar Oct 25 '22 11:10 dblair-cet

This would be very helpful especially since the Pulumi GitHub App is not working!

@dblair-cet what's not working specifically in the GH App?

praneetloke avatar Oct 31 '22 13:10 praneetloke