pulumi-awsx icon indicating copy to clipboard operation
pulumi-awsx copied to clipboard

IPAM tests cannot be run concurrently

Open corymhall opened this issue 1 year ago • 3 comments

What happened?

It looks like we have a limit of 1 ipam existing at a time, which means that we can only run that test with a concurrency of 1 across all workflow runs.

* creating IPAM: operation error EC2: CreateIpam, https response error StatusCode: 400, RequestID: 6fbeea5e-d315-4d99-bde7-9f8a2dac7574, api error ResourceLimitExceeded: You've reached the limit for ipams. You have created 1 ipams and you are limited to 1.
*

We could:

  • Run this test in a separate job with a concurrency of 1 across all workflow runs
  • Run this workflow only during the main workflow after PRs have been merged

Example

N/A

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

corymhall avatar Sep 17 '24 12:09 corymhall

What if we set up the IPAM & pool before the test (and just use it if it already exists). I think that way we should get around those limitations

flostadler avatar Sep 18 '24 10:09 flostadler

That's a good idea. We originally considered just creating a permanent one and using that since they are free, but decided not to because it didn't affect the test speed. The concurrency limitation makes it worth it I think.

corymhall avatar Sep 18 '24 12:09 corymhall

https://github.com/pulumi/pulumi-awsx/issues/1404 looks like @danielrbradley setup a test IPAM, but I need to confirm where is the infra that's managing it. If it is permanent we can rewrite the tests to get it. For now I will skip the tests.

t0yv0 avatar Nov 06 '24 14:11 t0yv0