pulumi-aws icon indicating copy to clipboard operation
pulumi-aws copied to clipboard

Automate removing Computed on tags_all for PF resources

Open t0yv0 opened this issue 1 year ago • 3 comments

Fixes https://github.com/pulumi/pulumi-aws/issues/2962

The change is related to https://github.com/pulumi/pulumi-aws/issues/3709 and most of it is folded into that patch; with this PR the tags_all attribute is changing to be non-Computed as before, but the change is no longer a source-level change but is a quick runtime pass instead. This removes the burden of patching the provider repeatedly for this concern.

Obsolete patches are removed.

Fixes https://github.com/pulumi/pulumi-aws/issues/3711 Fixes https://github.com/pulumi/pulumi-aws/issues/3714 Fixes https://github.com/pulumi/pulumi-aws/issues/3715 Fixes https://github.com/pulumi/pulumi-aws/issues/3717 Fixes https://github.com/pulumi/pulumi-aws/issues/3721 Fixes https://github.com/pulumi/pulumi-aws/issues/3725 Fixes https://github.com/pulumi/pulumi-aws/issues/3727

All removed patches:

patches/0029-Fix-markTagsAllNotComputedForResources-to-recognize-.patch patches/0032-DisableTagSchemaCheck-for-PF-provider.patch patches/0033-Run-scripts-patch_computed_only.sh-to-patch-eks-pod_.patch patches/0035-Fix-tags_all-Computed-for-PF-resources.patch patches/0039-Patch-osis_pipeline-tags-flags.patch patches/0041-Do-not-Compute-tags_all-of-aws_bedrock_provisioned_m.patch patches/0043-securitylake_subscriber-tags_all-patch.patch
patches/0044-Patch-tags-ComputedOnly-for-m2-resources.patch patches/0053-Patch-tags-ComputedOnly-on-bedrockagent-and-other-mo.patch patches/0055-Fix-tags_all-Computed-for-aws_datazone_domain.patch patches/0058-Fix-tags_all-Computed-for-PF-resources.patch patches/0059-Fix-tags_all-Computed-for-PF-resources.patch patches/0060-Fix-tags_all-Computed-for-PF-resources.patch patches/0062-Patch-tags-ComputedOnly-for-appfabric-networkmonitor.patch

t0yv0 avatar Jul 01 '24 20:07 t0yv0

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

github-actions[bot] avatar Jul 01 '24 20:07 github-actions[bot]

That's reasonable, we could build https://github.com/pulumi/pulumi-aws/issues/3022 first and then rearrange things so that the provider modifications happen so that upstream tests exercise our patches, it could be very valuable here.

t0yv0 avatar Jul 03 '24 19:07 t0yv0

Notes from team discussion: we can try running some upstream tests over PF, but probably targeting all modules is too hard; we'll target a few modules, exclude upstream tags tests if needed, and unblock this.

t0yv0 avatar Aug 22 '24 13:08 t0yv0

Closing since this was removed in v7

corymhall avatar Aug 15 '25 12:08 corymhall