pulumi-aws icon indicating copy to clipboard operation
pulumi-aws copied to clipboard

Fix rds.Cluster.engine value not usable with rds.ClusterInstance

Open vumdao opened this issue 1 year ago • 3 comments

Fix #2093

vumdao avatar May 28 '24 13:05 vumdao

PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] avatar May 28 '24 13:05 github-actions[bot]

Hello and thank you for your pull request! :heart: :sparkles: It looks like you're directly modifying files in the language SDKs, many of which are autogenerated. Be sure any files you're editing do not begin with a code generation warning. For generated files, you will need to make changes in resources.go instead, and generate the code.

github-actions[bot] avatar May 28 '24 13:05 github-actions[bot]

Hi @vumdao, Thank you for your contribution!

Unfortunately, the file that you edited is automatically generated by our tools and can't be edited manually. Otherwise, the change will be overwritten on the next generation.

To fix the issue, we would need to mark the property as a string | enum in the provider's schema, and then generate all SDKs off it. Copying @t0yv0 @flostadler @corymhall in case we can provide some help here.

mikhailshilkov avatar May 30 '24 15:05 mikhailshilkov

We cannot take this change just yet unfortunately, I will follow up on the ticket with the details.

t0yv0 avatar Sep 27 '24 20:09 t0yv0