pulumi-aws icon indicating copy to clipboard operation
pulumi-aws copied to clipboard

PATCH 0043-Revert-Merge-pull-request-35671-from-hashicorp-b-lb-.patch

Open t0yv0 opened this issue 1 year ago • 5 comments

0043-Revert-Merge-pull-request-35671-from-hashicorp-b-lb-.patch

This also reverts a bridge bug temporarily.

t0yv0 avatar Mar 25 '24 19:03 t0yv0

This reverts https://github.com/hashicorp/terraform-provider-aws/pull/35671

There is an open claim that this PR introduced https://github.com/hashicorp/terraform-provider-aws/issues/36459 which is still open upstream.

t0yv0 avatar May 20 '24 20:05 t0yv0

https://github.com/pulumi/pulumi-aws/pull/3426 introduced this

t0yv0 avatar May 20 '24 21:05 t0yv0

I'm revisiting this today because @corymhall is running into this patch creating friction in the routine update (https://github.com/pulumi/pulumi-aws/pull/3959).

It looks like we are not yet ready to remove it, @VenelinMartinov can you confirm if you have a good tracking issue in the bridge or should I create one based on this patch? It looks like an observable discrepancy in Read between bridged and TF proper, in what the provider implementation is able to observe in cty.Value somewhere.

t0yv0 avatar May 20 '24 21:05 t0yv0

I believe https://github.com/pulumi/pulumi-aws/issues/3427 tracks this patch but it looks like I didn't name it correctly.

The corresponding issue in the bridge is https://github.com/pulumi/pulumi-terraform-bridge/issues/1767 which I suspect is also fixed by https://github.com/pulumi/pulumi-terraform-bridge/pull/1971 but I have not got around to confirming that.

VenelinMartinov avatar May 21 '24 09:05 VenelinMartinov

That's excellent! We are in no particular rush here but tracking the issues helps as we can revisit this on some schedule to try closing when prerequisites are met. Thanks!

t0yv0 avatar May 21 '24 14:05 t0yv0

We might need to enrol the lb resources into PlanResourceChange for them to pick up https://github.com/pulumi/pulumi-terraform-bridge/pull/1971.

That should be available in the next bridge release.

VenelinMartinov avatar Jun 11 '24 14:06 VenelinMartinov

This issue has been addressed in PR #4083 and shipped in release v6.42.0.

pulumi-bot avatar Jun 27 '24 15:06 pulumi-bot